Skip to content

[GuestConfiguration] Include left out reportsV2 specs that is already…#3826

Merged
sarangan12 merged 1 commit intoAzure:masterfrom
viveklingaiah:vivekl/includeReportsV2LeftOutSpecs
Sep 7, 2018
Merged

[GuestConfiguration] Include left out reportsV2 specs that is already…#3826
sarangan12 merged 1 commit intoAzure:masterfrom
viveklingaiah:vivekl/includeReportsV2LeftOutSpecs

Conversation

@viveklingaiah
Copy link
Contributor

@viveklingaiah viveklingaiah commented Sep 7, 2018 •
edited
Loading

… approved

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

azuresdkci commented Sep 7, 2018

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@viveklingaiah
Copy link
Contributor Author

viveklingaiah commented Sep 7, 2018

This is related to my previous PR from yesterday #3809. I forgot to include the specs in this PR in it. These changes have already been approved by @jianghaolu when it was in private in https://github.com/Azure/azure-rest-api-specs-pr/pull/559. Please take a look and approve soon.

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@sarangan12 sarangan12 merged commit 6704d71 into Azure:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sarangan12 sarangan12 sarangan12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sarangan12 sarangan12

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@viveklingaiah @azuresdkci @AutorestCI @sarangan12